fix defaults for mingw builds #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
totaam
commented
Jan 15, 2024
totaam
commented
- we have to set BOOST_USE_WINDOWS_H=1 because of this bug: http://stackoverflow.com/questions/18134148
- remove '/EHsc' and '/FORCE' when compiling with mingw instead of msvc
Owner
|
Thanks. Your PR deletes two submodules that I think should be kept. Could you remove these deletions? |
* we have to set BOOST_USE_WINDOWS_H=1 because of this bug: http://stackoverflow.com/questions/18134148 * remove '/EHsc' and '/FORCE' when compiling with mingw instead of msvc
Contributor
Author
|
@inducer oops, sorry about that. Force pushed without those unwanted changes. |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.