Fix set_trace(paused=False) #688
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this gave an exception like
>>> pudb._get_debugger().set_trace(paused=False)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/aaronmeurer/miniconda3/lib/python3.11/site-packages/pudb/debugger.py", line 291, in set_trace
self.set_continue()
File "/Users/aaronmeurer/miniconda3/lib/python3.11/bdb.py", line 344, in set_continue
self._set_stopinfo(self.botframe, None, -1)
^^^^^^^^^^^^^
AttributeError: 'Debugger' object has no attribute 'botframe'
The fix is to always set the botframe variable, even when paused=False,
because after commit 2b08f08, the bdb
set_continue method is used, which requires botframe to be set.
asmeurer
commented
Jun 9, 2025
| @@ -262,24 +262,22 @@ def set_trace(self, frame=None, as_breakpoint=None, paused=True): | |||
| # See pudb issue #52. If this works well enough we should upstream to | |||
| # stdlib bdb.py. | |||
| # self.reset() | |||
|
|
|||
| if paused: | |||
There was a problem hiding this comment.
FYI the only change here is removing this line (this is clearer if you look at https://github.com/inducer/pudb/pull/688/files?w=1)
|
The type checker doesn't like these changes. How do I fix that? (it's kind of ironic; the type checker would have been useful if it had flagged these attributes as not being defined they way they were before, conditionally under the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this gave an exception like
The fix is to always set the botframe variable, even when paused=False, because after commit 2b08f08, the bdb set_continue method is used, which requires botframe to be set.