Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port deprecated uses of freeze and thaw #334

Merged
merged 1 commit into from
Jun 11, 2022

Conversation

alexfikl
Copy link
Collaborator

No description provided.

@alexfikl
Copy link
Collaborator Author

Checked the output in
https://github.com/inducer/meshmode/runs/6845138643?check_suite_focus=true
and everything seems to be clean now. There is a rather worrisome warning that I don't recall seeing before

/home/runner/work/meshmode/meshmode/.miniforge3/envs/testing/lib/python3.10/site-packages
/pytools/persistent_dict.py:567: CollisionWarning: loopy-typed-and-scheduled-cache-v1-2022.1-
islpy2022.1.2-cgen2020.1-a24370e8dfd417e24aa37cfb900b4425af3caab3-v1: key collision in cache 
at '/home/runner/.cache/pytools/pdict-v4-loopy-typed-and-scheduled-cache-v1-2022.1-
islpy2022.1.2-cgen2020.1-a24370e8dfd417e24aa37cfb900b4425af3caab3-v1-py3.10.4.final.0' -- 
these are sufficiently unlikely that they're often indicative of a broken hash key 
implementation (that is not considering some elements relevant for equality comparison)

Not sure where it comes from though 😟

@inducer
Copy link
Owner

inducer commented Jun 11, 2022

Bumped that to an issue, as it's almost certainly unrelated. As is, they're an efficiency issue (as they will trigger redundant work in loopy), but they should not impact correctness, so I think it's OK to proceed here.

Thanks for taking care of this!

@inducer inducer merged commit 97d99cb into inducer:main Jun 11, 2022
@alexfikl alexfikl deleted the deprecated-freeze-thaw branch June 11, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants