Skip to content

Fix stride check for zero-size arrays #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
inducer merged 4 commits into from
May 20, 2022
Merged

Fix stride check for zero-size arrays #624

inducer merged 4 commits into from
May 20, 2022

Conversation

@inducer
Copy link
Owner

@inducer inducer commented May 19, 2022

Closes #583.

@inducer inducer requested a review from kaushikcfd May 19, 2022 23:00
@inducer
Copy link
Owner Author

inducer commented May 19, 2022

@alexfikl, @nchristensen, @majosm, could you also take a look?

@inducer inducer mentioned this pull request May 19, 2022
Closed
@inducer inducer changed the title Zero size stride check Fix stride check for zero-size arrays May 19, 2022
@inducer inducer force-pushed the zero-size-stride-check branch from b166374 to dfbc1ce Compare May 19, 2022 23:13
alexfikl
alexfikl reviewed May 19, 2022
View reviewed changes
Copy link
Contributor

@alexfikl alexfikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is certainly a lot cleaner! LGTM!

@alexfikl
Copy link
Contributor

alexfikl commented May 19, 2022 •
edited
Loading

Does this also fix https://github.com/inducer/arraycontext/blob/981a546703d129a6c4c521000bb07b2eb3fbf4c3/test/test_arraycontext.py#L1017-L1021?

@inducer inducer force-pushed the zero-size-stride-check branch from dfbc1ce to ff498a1 Compare May 19, 2022 23:41
@majosm
Copy link
Contributor

majosm commented May 19, 2022

👍 This fixes all of the stride errors I was seeing.

inducer added a commit to inducer/arraycontext that referenced this pull request May 19, 2022
@inducer
Drop xfail in test_flatten_array_container
549c2b9 
Needs inducer/loopy#624.
@inducer
Copy link
Owner Author

inducer commented May 19, 2022

Does this also fix https://github.com/inducer/arraycontext/blob/981a546703d129a6c4c521000bb07b2eb3fbf4c3/test/test_arraycontext.py#L1017-L1021?

Yep, it does. Thanks for remembering that! When this is in: https://github.com/inducer/arraycontext/compare/drop-flatten-xfail?expand=1

@inducer inducer force-pushed the zero-size-stride-check branch from ff498a1 to 0598d93 Compare May 19, 2022 23:54
inducer
inducer commented May 20, 2022
View reviewed changes
kaushikcfd
kaushikcfd approved these changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@kaushikcfd kaushikcfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@inducer inducer force-pushed the zero-size-stride-check branch from 0598d93 to 65ee212 Compare May 20, 2022 04:25
@inducer inducer enabled auto-merge (rebase) May 20, 2022 04:26
@inducer
Copy link
Owner Author

inducer commented May 20, 2022

Thanks all for taking a look!

@inducer inducer mentioned this pull request May 20, 2022
Closed
@inducer inducer merged commit 8ca762f into main May 20, 2022
@inducer inducer deleted the zero-size-stride-check branch May 20, 2022 05:25
@inducer inducer mentioned this pull request May 20, 2022
Merged
inducer added a commit to inducer/arraycontext that referenced this pull request May 20, 2022
@inducer
Drop xfail in test_flatten_array_container
8d7c872 
Needs inducer/loopy#624.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaushikcfd kaushikcfd kaushikcfd approved these changes

+1 more reviewer

@alexfikl alexfikl alexfikl left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stride mismatch using fortran ordered (0,N) arrays

5 participants

@inducer @alexfikl @majosm @kaushikcfd