Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow limited semver-based updates of the lz4 dependency #1

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Allow limited semver-based updates of the lz4 dependency #1

merged 1 commit into from
Aug 13, 2019

Conversation

ankon
Copy link
Contributor

@ankon ankon commented Aug 13, 2019

lz4 0.6.0 doesn't work with NodeJS 12, support for that was added with lz4 0.6.3.

This PR changes the way this package depends on lz4 so that that update gets picked up automatically.

Copy link
Collaborator

@paambaati paambaati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@paambaati paambaati merged commit e072c12 into indix:master Aug 13, 2019
@ankon
Copy link
Contributor Author

ankon commented Aug 14, 2019

Thanks for merging! Can you also create a release in NPM for this change?

@ankon ankon deleted the pr/lz4-allow-semver-updates branch August 14, 2019 09:04
@paambaati
Copy link
Collaborator

@ankon Done! This has just landed in kafkajs-lz4@1.2.1 🎉

@paambaati paambaati added the bug Something isn't working label Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants