v0.17.0#139
Merged
Merged
Conversation
otherwise it always fails, meanwhile the reason is pretty dummy, and is the feature by itself
…t encoding (e.g. urlencoded + and & characters)
…while the actual implementation now provides a primitive functionality only
…icated version.go file
…ghtly modified methods docs
…d a bit more dumb (which is good)
…the whole ASCII set
… reporting at all
… saves a few bytes in total
…reader, which reduced a lot the amount of code needed and overall complexity
…, various bug fixes and enhances
this makes things a bit simpler and enables optimization with `io.WriterTo` in serializer when sending attachments
renamed URL to URI as it is more correct. Removed Body.MaxChunkSize as non-relevant. Removed Query and moved its contents into URI. Removed Body.DecodingBufferSize
the Retriever interface is now Fetcher with Fetch() method instead of previous Retrieve(). The reason is that "to fetch" sounds more naturally and better-suited for the usecase.
… function for search
indigo-web/utils/uf was replaced by flrdv/uf. Other subpackages were interned directly (if were used at all); chunked body parser was completely rewritten. The reason is due to rapid development (as the project is still under the v1.0.0 version) it is sometimes a pain in the ass updating utils, committing, pushing updates, releasing & only then upgrading it in indigo itself. Another reason was a consideration that packages contained there aren't that much essential and generic. Moreover, most part of them isn't relevant anymore (e.g. constraint) or unused (e.g. mapconv)
this produces less visual garbage and less unnecessary files.
even though fetcher was on purpose distinct from transport.Client.Read() method, in tests is it often easier and more adequate solution to simply reuse the dummy circular client.
now the request path is validated by the parser, thereby the path is guaranteed to include no non-printable characters, making it safe-to-print by default.
as kv was moved to project top, it's accessible by the user directly now. Query isn't needed anymore as the parser parses it by itself directly. Path utilities are also not needed anymore, as it existed only because of lack of parser's request path validation. Now it validates.
we cannot detect at the moment, whether the read error was actually a timeout error. Well, it's possible, however errors generated by net package are composed and honestly pretty much idiotic. Other removed errors are simply not used anymore or just duplicate some already existing ones.
…with errors occurred during parsing the protocol version
…nal naming, minor tweaks now request path is validated, thereby providing guarantees to not contain any non-printable ascii characters. Request parameters are parsed in-place, thereby abolishing the old "lazy" approach, which was only inconvenient and generally smelled. Updated the signature, removing the need to check the parser against its state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
major internal restructuring.
Request.QuerytoRequest.ParamsRequest.ParamstoRequest.Vars