Zoom Rooms - improvements in base Zoom plugin #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
pferreir
force-pushed
the
zoom-rooms
branch
4 times, most recently
from
eec817a
to
8efeb20
Compare
pferreir
force-pushed
the
zoom-rooms
branch
3 times, most recently
from
c772110
to
5cdf0d5
Compare
tomasr8
reviewed
Oct 15, 2024
mypy.ini
Outdated
| @@ -0,0 +1,2 @@ | |||
| [mypy] | |||
| disable_error_code = misc, import-untyped, import-not-found | |||
There was a problem hiding this comment.
Should we perhaps start running mypy in the CI? The zoom plugin currently passes without warnings
There was a problem hiding this comment.
Actually, do we even need import-not-found there?
There was a problem hiding this comment.
But yeah, I vote in favour. But maybe in a separate PR? 😄
There was a problem hiding this comment.
Or Pyright (used by Pylance) which tends to have fewer false positives and doesn't lag behind new features as much as mypy does
There was a problem hiding this comment.
At some point (next year would be my guess) there will probably be a type checker from the ruff/uv guys as well... ;)
pferreir
force-pushed
the
zoom-rooms
branch
2 times, most recently
from
4e4187d
to
e08daa8
Compare
ThiefMaster
reviewed
Oct 28, 2024
ThiefMaster
reviewed
Oct 28, 2024
pferreir
force-pushed
the
zoom-rooms
branch
2 times, most recently
from
27fb948
to
9196c02
Compare
ThiefMaster
approved these changes
Nov 4, 2024
ThiefMaster
force-pushed
the
zoom-rooms
branch
from
0b1ae95
to
8b94099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes with indico/indico#6475
Main changes (Zoom):
The TS PR is also included, since I rely on it.