-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Partial Team Reg #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, we could refactor in some places, i see a bunch of ternaries in the create_transaction
and in the RazorpayPayment
component that is slightly hard to read. And the create transaction function is also quite big, could think about breaking it up, could make it easier to read.
Otherwise all good
<span class="me-2 rounded bg-red-100 px-2.5 py-0.5 text-xs font-medium text-red-800 dark:bg-red-900 dark:text-red-300"> | ||
Partial | ||
</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we show this only to the team admin ? I don't think all users need to know the teams' payment status right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I thought it be better cause OPs also would wanna know and it avoids misconception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, makes sense. We can think about an ops role for the Hub later on maybe, for things like this, and if there's a need. Fine for now
No description provided.