Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Partial Team Reg #397

Merged
merged 14 commits into from
Oct 12, 2024
Merged

Feature: Partial Team Reg #397

merged 14 commits into from
Oct 12, 2024

Conversation

Joe2k
Copy link
Contributor

@Joe2k Joe2k commented Oct 9, 2024

No description provided.

@Joe2k Joe2k requested a review from SibiAkkash October 9, 2024 19:58
Copy link
Contributor

@SibiAkkash SibiAkkash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we could refactor in some places, i see a bunch of ternaries in the create_transaction and in the RazorpayPayment component that is slightly hard to read. And the create transaction function is also quite big, could think about breaking it up, could make it easier to read.
Otherwise all good

Comment on lines +410 to +412
<span class="me-2 rounded bg-red-100 px-2.5 py-0.5 text-xs font-medium text-red-800 dark:bg-red-900 dark:text-red-300">
Partial
</span>
Copy link
Contributor

@SibiAkkash SibiAkkash Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we show this only to the team admin ? I don't think all users need to know the teams' payment status right ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I thought it be better cause OPs also would wanna know and it avoids misconception

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, makes sense. We can think about an ops role for the Hub later on maybe, for things like this, and if there's a need. Fine for now

@Joe2k Joe2k merged commit 75f0ff1 into main Oct 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants