Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal to edit player roles #250

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SibiAkkash
Copy link
Contributor

@SibiAkkash SibiAkkash commented Jan 3, 2024

edit-player-roles-2024-01-03_20.23.57.mp4

@punchagan can you push the API changes ? I'll test against that

The <dialog> tag is my new favorite html tag 😄

Fixes #251

@Joe2k
Copy link
Contributor

Joe2k commented Jan 3, 2024

Any pros of using dialog over the flowbite modal we were using till now?

But yeah just read and it does give good out of box capability to open and close nicely

@SibiAkkash
Copy link
Contributor Author

Any pros of using dialog over the flowbite modal we were using till now?

But yeah just read and it does give good out of box capability to open and close nicely

I was seeing some issues with flowbite modals, for example the score modals sometimes wouldn't open. And we won't have to do flowbite init a bunch of times, to get it working.
The dialog tag is fully browser supported, so this could be better

@SibiAkkash
Copy link
Contributor Author

Any pros of using dialog over the flowbite modal we were using till now?

But yeah just read and it does give good out of box capability to open and close nicely

Exactly

@SibiAkkash SibiAkkash force-pushed the edit-player-roles branch 2 times, most recently from 69e8eea to 722a07e Compare January 4, 2024 08:12
Before v3.4.0 we couldn't use max-w-[any pixel value]
https://tailwindcss.com/docs/max-width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add button for staff users to edit player roles
2 participants