Locks event-stream to 3.3.4 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Nov 26, 2018
davidpelayo
approved these changes
Nov 26, 2018
|
Thanks. Getting ramped up on this. Should have a fix out soon. |
This was referenced Nov 26, 2018
|
Thank you for the urgent fix! |
ciyer
pushed a commit
to SwissDataScienceCenter/renku-ui
that referenced
this pull request
Nov 27, 2018
We use npm-run-all to build css before running the app in development mode. The version we were using depends, through ps-tree, on the event-stream package which has been compromised. - indexzero/ps-tree#34 - dominictarr/event-stream#116 - dominictarr/event-stream#115 Upgrading to the latest npm-run-all fixes this issue.
ableuler
pushed a commit
to SwissDataScienceCenter/renku-ui
that referenced
this pull request
Nov 27, 2018
We use npm-run-all to build css before running the app in development mode. The version we were using depends, through ps-tree, on the event-stream package which has been compromised. - indexzero/ps-tree#34 - dominictarr/event-stream#116 - dominictarr/event-stream#115 Upgrading to the latest npm-run-all fixes this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an ongoing issue with
event-streamsince a malicious person took over, see here.Either way, this locks to a known good version.