Update package.json #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nelsonic Can I add you as contributor? @indexzero Any chances to add one of @zixia or @nelsonic or @simonepri inside the contributors on |
This was referenced Mar 16, 2018
nelsonic
reviewed
Mar 20, 2018
| }, | ||
| "scripts": { | ||
| "_comment": "https://github.com/gotwarlost/istanbul#usage-on-windows", | ||
| "test": "istanbul cover node_modules/tape/bin/tape test/test.js test/direct.js", | ||
| "coverage": "npm test && istanbul check-coverage --statements 100 --functions 100 --lines 100 --branches 100", | ||
| "codeclimate": "cross-env CODECLIMATE_REPO_TOKEN=84436b4f13c70ace9c62e7f04928bf23c234eb212c0232d39d7fb1535beb2da5 codeclimate < coverage/lcov.info" | ||
| }, | ||
| "dependencies": { | ||
| "event-stream": "~3.3.0" |
There was a problem hiding this comment.
It's unclear from this PR where event-stream is being used.
Perhaps consider adding detail to the PR description as to why/where it is required. 🤔
There was a problem hiding this comment.
event-stream is already in the package.json
I just reordered the keys
nelsonic
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
bugspropertykeyboardpropertymainandbinpropertyfilesproperty removing.npmignorerepositorypropertyRef #26
Please merge this before #27
cc @nelsonic @indexzero @zixia @soyuka