Sync with indexmap and release 1.0.0 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 3dbac6a)
(cherry picked from commit 09fb43f)
(cherry picked from commit 2c150ab)
It's the same type as from `std::collections::hash_map`, just a different export path, so this isn't a breaking change. (cherry picked from commit 38fb76a)
(cherry picked from commit c115d26)
(cherry picked from commit cfff4b7)
(cherry picked from commit 4849b16)
(cherry picked from commit b46a32a)
It's a valuable test to have, but it's quite a bit slower than everything else, and there's not much value in running it twice, for both the pull request and merge queue. (cherry picked from commit 61c9c94)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indexmapdependency to version 2.12.0.pop_ifmethods toOrderMapandOrderSet, similar to the method forVecadded in Rust 1.86.I've stated that MSRV changes will be limited to minor versions, but since we were a 0.x crate, that would require bumping to semver-incompatible version. If we're going to do that, let's just make it 1.0!