Factor out "OrderMapCore" and other generics bloat saving measures #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce generics bloat, factor out a whole lot of the code that does not depend on the type parameter S (the hasher). This also means we get an `Entry<K, V>` without S which matches the standard `HashMap`.
The closures are used once per iterator method this way, and we don't want that duplication. Use accessors on the Bucket struct instead. This saves several trans items (if several methods on an iterator are used).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each compiled item we ideally want it to depend on the least amount of type parameters, so that it can be shared between different parameterizations of OrderMap. To this end, factor out the part of ordermap that does not depend on S (the hasher). This also seems like a cleaner design, even if it needs some more wrapper methods.
As a bonus, this resolves the issue where we had one more parameter than the standard
HashMap'sEntry<K, V>-- ordermap's entry is now identical.Also reduce the number of closures used in the iterators.