Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajout bordure autour des labels #1036

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Ajout bordure autour des labels #1036

merged 1 commit into from
Nov 15, 2024

Conversation

fabienheureux
Copy link
Member

Description succincte du problème résolu

Cf retours de Delphine, il manque des bordures autours des labels

image

Ceci corrige cela

Type de changement :

  • Bug fix
  • Nouvelle fonctionnalité
  • Mise à jour de données / DAG
  • Les changements nécessitent une mise à jour de documentation
  • Refactoring de code (explication à retrouver dans la description)

Auto-review

Les trucs à faire avant de demander une review :

  • J'ai bien relu mon code
  • La CI passe bien
  • En cas d'ajout de variable d'environnement, j'ai bien mis à jour le .env.template
  • J'ai ajouté des tests qui couvrent le nouveau code

@fabienheureux fabienheureux requested a review from a team as a code owner November 15, 2024 10:44
@fabienheureux fabienheureux requested review from kolok and maxcorbeau and removed request for a team November 15, 2024 10:45
kolok
kolok reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@kolok kolok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabienheureux fabienheureux merged commit 4b6bc6b into main Nov 15, 2024
7 checks passed
@fabienheureux fabienheureux deleted the last-feedbacks-fiche-detaillee branch November 15, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolok kolok kolok left review comments

@maxcorbeau maxcorbeau Awaiting requested review from maxcorbeau maxcorbeau is a code owner automatically assigned from incubateur-ademe/lvao-admin

Assignees

@kolok kolok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabienheureux @kolok