Setup publiopti #1697
Merged
Setup publiopti #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report for the pull request #1697🚀 Test the model from the website: https://nosgestesclimat.fr?PR=1697 🔧 Model compilation status
🌐 Translation statusRules
Personas
👫 Personas changesTest personas regression
Test model optimisation
|
EmileRolley
force-pushed
the
fix-optim
branch
7 times, most recently
from
b8c6f3f
to
7fe2fe2
Compare
EmileRolley
force-pushed
the
fix-optim
branch
from
5062b4c
to
65b3483
Compare
EmileRolley
changed the title
8 tasks
EmileRolley
force-pushed
the
fix-optim
branch
2 times, most recently
from
3280333
to
1772c39
Compare
EmileRolley
force-pushed
the
fix-optim
branch
2 times, most recently
from
f0b02d0
to
cc60df5
Compare
Clemog
reviewed
Feb 16, 2023
laem
reviewed
Feb 21, 2023
|
@EmileRolley what kind of review do you need from me, if any ? |
EmileRolley
force-pushed
the
fix-optim
branch
from
470a785
to
f439d0a
Compare
A basic code review I think, and some checks on the preview to make sure I haven't forgotten any rules. |
EmileRolley
force-pushed
the
fix-optim
branch
2 times, most recently
from
d5274d1
to
54ef339
Compare
EmileRolley
force-pushed
the
fix-optim
branch
from
54ef339
to
14061c9
Compare
EmileRolley
force-pushed
the
fix-optim
branch
from
80a45a2
to
5b7be61
Compare
EmileRolley
force-pushed
the
fix-optim
branch
from
5b7be61
to
757882e
Compare
EmileRolley
added a commit
to incubateur-ademe/nosgestesclimat-site
that referenced
this pull request
Feb 27, 2023
Feat: activation de l'optimisation du modèle avec publiopti follows incubateur-ademe/nosgestesclimat#1697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup the model optimisation with
publioptiachieving a ~65% reduction in the number of rules.Remarks
When working on the rules optimisation, I discovered empty rules inside the base model such as
pétroleorlogement . gaz. Deleting them doesn't seem to be a problem for the simulation.As full rules are loaded to render documentation page, it isn't an issue to remove them from the optimized model, right? @Clemog
Changelog
sommemechanisms in theempreinte nationale.yamlfile.icone->icônesinalimentation.yamlicônesattribute from the optimisation.publicodesto the1.0.0-beta.66version.rulesToJSONscript -- closes Documenter et refactorerrulesToJSONscript #1716.yarn test:optimto compare personas results between the optim and the base model.