Skip to content

Add search issues command and refactoring #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 13, 2022
Merged

Add search issues command and refactoring #7

merged 5 commits into from
Oct 13, 2022

Conversation

mziyut
Copy link

@mziyut mziyut commented Oct 12, 2022 •
edited
Loading

What

  • Add search issues command and refactoring
    • Add <@ruboty search issues "<query>"> command.
    • Change of definitions deprecated in rspec.
      • Migrate matchers should -> expect to.
      • Remove deprecated option config.treat_symbols_as_metadata_keys_with_true_values.
  • Add test workflow on GitHub Actions
    • Define GitHub Actions to run rspec. Target Ruby versions are 2.7, 3.0, and 3.1.
  • Setup dependabot
    • Target ecosystem for github-actions and bundler
  • Add rubocop, rubocop-rake, rubocop-performance, rubocop-rspec gems
  • Use rubocop autocorrect and modify the code
    • Exec bundle exec rubocop -A

Reference

@mziyut mziyut self-assigned this Oct 12, 2022
@mziyut mziyut marked this pull request as ready for review October 12, 2022 03:50
@mziyut mziyut force-pushed the add-search-issues branch 5 times, most recently from 6de7093 to dcb4112 Compare October 12, 2022 05:22
@mziyut mziyut requested a review from getty104 October 12, 2022 05:24
@mziyut mziyut force-pushed the add-search-issues branch from dcb4112 to 8cc9241 Compare October 12, 2022 05:27
@mziyut mziyut requested a review from Umekawa October 12, 2022 09:25
getty104
getty104 reviewed Oct 12, 2022
View reviewed changes
@mziyut mziyut force-pushed the add-search-issues branch from 8cc9241 to f33079f Compare October 13, 2022 00:44
@codeclimate
Copy link

codeclimate bot commented Oct 13, 2022

Code Climate has analyzed commit f33079f and detected 0 issues on this pull request.

View more on Code Climate.

@mziyut mziyut requested a review from getty104 October 13, 2022 00:53
Umekawa
Umekawa approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@Umekawa Umekawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

getty104
getty104 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@getty104 getty104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mziyut mziyut merged commit 9d24372 into master Oct 13, 2022
@mziyut mziyut deleted the add-search-issues branch October 13, 2022 11:21
@mziyut mziyut mentioned this pull request Oct 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Umekawa Umekawa Umekawa approved these changes

@getty104 getty104 getty104 approved these changes

Assignees

@mziyut mziyut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mziyut @Umekawa @getty104