-
Notifications
You must be signed in to change notification settings - Fork 30
Fix github action version by hash #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates several GitHub Actions references in the test workflow to use specific commit SHAs for stronger pinning.
- Pinned
tj-actions/branch-names
,actions/checkout
,ruby/setup-ruby
, andpaambaati/codeclimate-action
to their respective commit SHAs - Added inline comments indicating the original semantic version for clarity
uses: tj-actions/branch-names@v7.0.7 | ||
- uses: actions/checkout@v3 | ||
- uses: ruby/setup-ruby@v1 | ||
uses: tj-actions/branch-names@6c999acf206f5561e19f46301bb310e9e70d8815 # v7.0.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a brief comment at the top of the workflow explaining the security rationale for pinning actions by full SHA, so future maintainers understand the practice.
Copilot uses AI. Check for mistakes.
- uses: actions/checkout@v3 | ||
- uses: ruby/setup-ruby@v1 | ||
uses: tj-actions/branch-names@6c999acf206f5561e19f46301bb310e9e70d8815 # v7.0.7 | ||
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider centralizing these pinned SHAs into workflow-level variables or a shared configuration file to simplify bulk updates across multiple workflows.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What