Fix github action version by hash #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates several GitHub Actions references in the test workflow to use specific commit SHAs for stronger pinning.
- Pinned
tj-actions/branch-names,actions/checkout,ruby/setup-ruby, andpaambaati/codeclimate-actionto their respective commit SHAs - Added inline comments indicating the original semantic version for clarity
| uses: tj-actions/branch-names@v7.0.7 | ||
| - uses: actions/checkout@v3 | ||
| - uses: ruby/setup-ruby@v1 | ||
| uses: tj-actions/branch-names@6c999acf206f5561e19f46301bb310e9e70d8815 # v7.0.7 |
There was a problem hiding this comment.
Add a brief comment at the top of the workflow explaining the security rationale for pinning actions by full SHA, so future maintainers understand the practice.
| - uses: actions/checkout@v3 | ||
| - uses: ruby/setup-ruby@v1 | ||
| uses: tj-actions/branch-names@6c999acf206f5561e19f46301bb310e9e70d8815 # v7.0.7 | ||
| - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0 |
There was a problem hiding this comment.
[nitpick] Consider centralizing these pinned SHAs into workflow-level variables or a shared configuration file to simplify bulk updates across multiple workflows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What