Skip to content

Add code owners and remove reviewers from dependabot #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add code owners and remove reviewers from dependabot #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# package-ecosystem: github-actions, directories: /
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line appears to be a comment using syntax (package-ecosystem, directories) that is typically found in dependabot.yml configuration files, not CODEOWNERS files.

In a CODEOWNERS file, lines starting with # are treated as comments and do not define any ownership rules. While this line is syntactically valid as a comment, its content might be confusing for future maintainers for a few reasons:

  1. It doesn't establish any code ownership itself.
  2. It might incorrectly imply that CODEOWNERS rules are being applied based on package-ecosystem or for all directories: / in the context of GitHub Actions, which is not how CODEOWNERS patterns work. The actual ownership rule is defined on the next line and is specific to the /.github/workflows path.

Could you clarify the purpose of this comment? If it's not essential for understanding the subsequent rule or if it was an accidental inclusion, consider removing it to improve the clarity of the CODEOWNERS file and prevent potential misinterpretations about its effect.

/.github/workflows @increments/qiita-dev-group
2 changes: 0 additions & 2 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,3 @@ updates:
day: "monday"
time: "14:00"
timezone: "Asia/Tokyo"
reviewers:
- "increments/qiita-dev-group"