Skip to content

Fix github action version by hash #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Fix github action version by hash #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: "20.16.0"
registry-url: "https://registry.npmjs.org"
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: xt0rted/block-autosquash-commits-action@v2
- uses: xt0rted/block-autosquash-commits-action@79880c36b4811fe549cfffe20233df88876024e7 # v2.2.0
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}

Expand All @@ -28,8 +28,8 @@ jobs:
needs:
- check_test_execution_conditions
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: "20.16.0"
- run: yarn install
Expand All @@ -47,8 +47,8 @@ jobs:
needs:
- check_test_execution_conditions
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: ${{ matrix.node }}
- run: yarn install
Expand All @@ -60,8 +60,8 @@ jobs:
needs:
- check_test_execution_conditions
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: "20.16.0"
- run: yarn install
Expand Down
2 changes: 1 addition & 1 deletion actions/publish/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ inputs:
runs:
using: "composite"
steps:
- uses: actions/setup-node@v4
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning the actions/setup-node action to a specific commit hash (49933ea5288caeca8642d1e84afbd3f7d6820020) is a great step for security!

However, there appears to be a small discrepancy in the accompanying version comment. The comment # v4.4.0 suggests this hash corresponds to version 4.4.0 of actions/setup-node. Upon checking, the commit 49933ea5288caeca8642d1e84afbd3f7d6820020 is actually tagged as v4.0.0 in the actions/setup-node repository (see actions/setup-node@v4.0.0).

An accurate version comment is important for future maintainability and understanding. Could you please verify this and update the comment to # v4.0.0?

Also, note that the @v4 tag currently points to a newer version (e.g., v4.0.2). If your intention was to pin to the latest stable v4 release, you might consider using the hash for that version. However, pinning to v4.0.0 is perfectly valid; the main point here is to ensure the comment accurately reflects the pinned version.

    - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.0.0

with:
node-version: "20.16.0"
- name: Install qiita-cli
Expand Down