Repository navigation
fix(web): collapse the pull request panel header on scroll again - #693
Merged
Merged
Conversation
A conflict resolution gated the panel's collapsing header behind a chromeVariant prop that no caller passes, so the header never folded into its compact row when a tab scrolled. Drop the prop and the gate so the header condenses on scroll and unfolds at the top again. Written by Claude Code (claude-opus-5-5).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request panel's header is meant to fold into a single compact row as you scroll a tab, then expand again at the top. Upstream has always done this, but the fork's header never collapses.
An earlier upstream intake removed the
chromeVariantprop and made collapsing unconditional (pingdotgg#7148). Resolving the conflict with the fork put the gate back:condensedonce again requiredchromeVariant === "collapse", and the scroll handler returned early unless that held. No caller passeschromeVariant, so the compact row, including its Conflicts badge, could never appear. The fork feature ledger records no such difference.This removes the gate: the prop, its type and default, and the early return. That section of
PullRequestDetailPanel.tsxis now identical to upstream at the current intake point (6975efd3dd).Recordings, which scroll down through the description and back to the top:
Before:
collapse-before.mp4
After:
collapse-after.mp4
Validation: I recorded the same steps on a PR with merge conflicts (#551) in a headless browser, on
mainand on this branch.main, the full header stays put while scrolling.The Conflicts badge in the compact row is also restyled by #691, which becomes visible once this lands.
Written by an agent (Claude Code, claude-opus-5-5).