Repository navigation
chore(ledger): record unpin confirmation against upstream - #650
Merged
Merged
Conversation
Assess the thread-unpin-confirmation entry against upstream: upstream ships web confirmation as an opt-in setting and has none on mobile, although the issue it closed asked for both clients.
incognitojam
changed the title
incognitojam
force-pushed
the
styal/ledger-unpin-confirmation
branch
from
October 6, 2026 15:18
97db899 to
094a2c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
thread-unpin-confirmationledger entry was added during the last intake to keep the fork's mobile unpin confirmation, but it was not assessed against upstream and recorded only part of the difference.Upstream added the confirmation to web as an opt-in setting, off by default (pingdotgg#7313), and has no confirmation on mobile, although the request it closed (pingdotgg#6009) asked for mobile to behave the same way. The fork confirms by default on web, desktop, and mobile.
The entry now:
rationalehow the fork differs and that it came from fork commit75082f7ea3and the fork's import of feat(web): add toggleable confirmation before unpinning a thread pingdotgg/t3code#7313 rather than a fork pull request;partialand tracks [Feature]: Confirm before unpinning a thread pingdotgg/t3code#6009 and feat(web): add toggleable confirmation before unpinning a thread pingdotgg/t3code#7313;Ledger only; the ledger check validates all 91 entries.
Written by an agent (Claude Code, claude-opus-5-5).