Repository navigation
chore(upstream): track the pull request state icons - #527
Merged
Merged
Conversation
incognitojam
added a commit
that referenced
this pull request
Sep 29, 2026
Release notes listed every commit since the previous release, so docs, CI, and intake bookkeeping commits such as #527 appeared next to app changes. The desktop update popover renders the same notes, so users saw them there too. ## Change `render_release_notes` now lists a commit only when it changes shipped code: a file under `apps/web`, `apps/desktop`, `apps/mobile`, `apps/server`, `packages/`, or `patches/`, excluding tests, test fixtures and helpers, `scripts/` folders, integration suites, and Markdown. The remaining commits are counted on the Full Changelog line: ``` **Full Changelog**: https://github.com/incognitojam/styal/compare/…430...…431 (includes 6 docs, CI, test, and tooling changes not listed above) ``` The desktop updater already skips the Full Changelog line, so the count does not appear as a change in the popover. Nightly and stable releases share the renderer, so both get the filter. The rule uses changed paths rather than the commit subject. #38 removed an earlier subject-based filter because it could hide user-facing changes made in `ci` or release commits; with paths, a `ci(release)` commit that changes desktop code is still listed. Relay changes are not listed because the relay deploys from `main` through `deploy-relay.yml`, not with releases. ## Validation - Rendered notes with the new function against the real tags for three published nightlies and compared them with the published bodies: - `v0.1.0-nightly.20260928.430`: only the web fix (#503) remains; `docs(agents)` #505 and `chore(upstream)` #506 are counted instead. - `v0.1.0-nightly.20260928.431`: 6 commits dropped, all `ci` and `chore(upstream)`, including #527. - `v0.1.0-nightly.20260926.422`: 15 dropped. Apart from docs, CI, tests, and intake bookkeeping, these are three `infra/relay` fixes and two upstream macOS installer artwork cherry-picks that are empty in the fork (their intake notes say "Not applied"), so the published notes listed changes that were not in the build. - Ran the rendered notes for nightly 430 through `normalizeDesktopUpdateReleaseNotes`, as Markdown and as GitHub-rendered HTML. Both produce the single listed change and no count item. - `vp test run scripts/release-changelog.test.ts` (36 passed): path classification cases, a mixed fork and upstream render with the omitted count, and a release where every commit is internal. - Not verified: a full nightly or stable workflow run with this change. Still listed: version bump commits (`chore(release): prepare …`, `chore(mobile): bump app version`) and refactors, because they change app files. Commits that change only the lockfile are not listed. --- Written by an agent (Claude Code, claude-opus-5-5).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request badge in the sidebar and composer uses the same icon for every state, so draft, closed and merged pull requests differ only by colour. Upstream fixed this in pingdotgg#11144, which gives each state its own icon: open, draft, closed and merged. A stack keeps the layers icon.
This PR adds pingdotgg#11144 to
.github/upstream-tracked-prs.json. It was merged upstream on 2026-09-16 and is not yet onmainor any intake branch.node scripts/upstream-tracked-prs-report.tslists it as pending, 5.9 days ahead of the fork tip, andscripts/upstream-tracked-prs.test.tspasses.Written by an agent (Claude Code, claude-opus-5-5).