Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve workshop preview images on the initiatives page (resolves #446) #447

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

cindyli
Copy link
Contributor

@cindyli cindyli commented Dec 7, 2020

  • This pull request has been linted by running npm run lint without errors
  • This pull request has been tested by running npm run start and reviewing affected routes
  • This pull request has been built by running npm run build without errors
  • This isn't a duplicate of an existing pull request

Description

Applied changes described in #446 for the Initiatives page.

Steps to test

  1. Go to Airtable -> base "WeCount_DEV", "preview_alt_text" and "cover_alt_text" fields should be in place;
  2. Go to the initiatives page, check:
  • Workshop preview images are no longer links;
  • For workshops that have "preview_alt_text" set in the Airtable, alt value for this workshop preview image should have been set to the alt value;
  • For workshops that don't have "preview_alt_text" set in the Airtable, this workshop preview image tags should have `role="presentation".
  1. Click on a workshop title to go to the workshop information page. Check:
  • If this workshop has a cover image uploaded in the Airtable, the cover image should be displayed on the page and its alt text is set to the value that's defined in the Airtable "cover_alt_text" field;
  • If the workshop doesn't have a cover image uploaded in the Airtable, nothing is shown as the cover image on this page.

Expected behavior:

See above.

@cindyli cindyli added this to the 2.4.0 milestone Dec 7, 2020
@cindyli cindyli requested a review from TeddTech December 7, 2020 19:18
@cindyli cindyli self-assigned this Dec 7, 2020
@cindyli cindyli merged commit c0e103c into inclusive-design:dev Dec 7, 2020
@cindyli cindyli deleted the workshop-preview-images branch December 7, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants