Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support featured images (resolves #281) #278

Merged
merged 5 commits into from
Jun 12, 2020

Conversation

cindyli
Copy link
Contributor

@cindyli cindyli commented Jun 11, 2020

  • This pull request has been linted by running npm run lint without errors
  • This pull request has been tested by running npm run start and reviewing affected routes
  • This pull request has been built by running npm run build without errors
  • This isn't a duplicate of an existing pull request

Description

Support the display of featured images on the grid of "Views" page and post articles.

Steps to test

  1. Go to "Views" page;
  2. Featured images are displayed in the grid and match the design; articles that don't have featured images display placeholder images;
  3. Select an article that has the featured image;
  4. The featured image should be displayed on the article page and match the design;
  5. Go back to the "Views" page and select a post that doesn't have the featured image;
  6. No images should be shown on the article page.

@cindyli cindyli changed the title feat: support featured images on the Views grid feat: support featured images (resolves #281) Jun 12, 2020
@cindyli cindyli requested a review from TeddTech June 12, 2020 15:44
@cindyli cindyli self-assigned this Jun 12, 2020
@cindyli
Copy link
Contributor Author

cindyli commented Jun 12, 2020

@TeddTech , there was an issue that the post preview contents are narrower on the mobile layout. See the screenshot below. I fixed in the new commit. Can you take a look again? Thanks.

Screen Shot 2020-06-12 at 12 47 09 PM

@TeddTech TeddTech self-requested a review June 12, 2020 17:17
@cindyli cindyli merged commit 0bac839 into inclusive-design:dev Jun 12, 2020
@cindyli cindyli deleted the feat/feature-image-for-views branch June 12, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants