Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix html validation errors and warnings #302

Closed
cindyli opened this issue Jun 19, 2020 · 2 comments
Closed

Fix html validation errors and warnings #302

cindyli opened this issue Jun 19, 2020 · 2 comments
Assignees
@cindyli
Labels
bug Something isn't working
Milestone
2.2.0

Comments

@cindyli
Copy link
Contributor

cindyli commented Jun 19, 2020

Describe the bug

Run webpages through W3C html validator. The same set of 2 errors and 2 warnings are reported, which should be fixed

To Reproduce

Steps to reproduce the behavior:

  1. Go to W3C html validator;
  2. In "Validate by URI" tab, enter "https://dev--wecount.netlify.app/" and click the "check" button;
  3. The report as the attached screenshot is reported.

Expected behavior

All issues causing errors and warnings should be fixed.

Screenshots

Screen Shot 2020-06-19 at 10 40 30 AM
@cindyli cindyli added the bug Something isn't working label Jun 19, 2020
@cindyli cindyli self-assigned this Jun 19, 2020
@cindyli cindyli added this to the 2.2.0 milestone Jun 19, 2020
cindyli added a commit to cindyli/wecount.inclusivedesign.ca that referenced this issue Jun 19, 2020
@cindyli
fix: fix html validation errors and warnings (resolves inclusive-desi…
54f6e99 
…gn#302) (inclusive-design#303)
cindyli added a commit to cindyli/wecount.inclusivedesign.ca that referenced this issue Jun 19, 2020
@cindyli
fix: fix html validation errors and warnings (resolves inclusive-desi…
4391672 
…gn#302) (inclusive-design#303)
@TeddTech
Copy link
Contributor

I believe this issue can be closed now because the PR associated with (#303) it has been merged

@cindyli
Copy link
Contributor Author

cindyli commented Jun 23, 2020

Good point, @TeddTech.

This issue can be close as the PR #303 for fixing it has been merged.

@cindyli cindyli closed this as completed Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cindyli cindyli

Labels
bug Something isn't working
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@cindyli @TeddTech