Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add focus/hover styling to uio contrast options #231

Closed
TeddTech opened this issue May 8, 2020 · 0 comments · Fixed by #233
Closed

Add focus/hover styling to uio contrast options #231

TeddTech opened this issue May 8, 2020 · 0 comments · Fixed by #233
Assignees
@TeddTech
Labels
enhancement New feature or request
Milestone
2.1.0

Comments

@TeddTech
Copy link
Contributor

TeddTech commented May 8, 2020

Is your feature request related to a problem? Please describe.

No focus styling for uio contrast options.

Describe the solution you'd like

Implement focus styling for each uio contrast option.

Describe alternatives you've considered

N/A

Additional context

I will be using @mixins/@includes to reduce code redundancy
@TeddTech TeddTech added the enhancement New feature or request label May 8, 2020
@TeddTech TeddTech self-assigned this May 8, 2020
@TeddTech TeddTech mentioned this issue May 11, 2020
Merged
4 tasks
@cindyli cindyli added this to the 2.1.0 milestone May 12, 2020
@cindyli cindyli changed the title Add focus styling to uio contrast options Add focus/hover styling to uio contrast options May 12, 2020
cindyli added a commit that referenced this issue Jun 9, 2020
@TeddTech @cindyli
fix: UIO focus styling (resolves #231) (#233)
6e375bc 
* fix: focus/hover styling to cards and search for uio contrast options

* fix: remove card svg from uio contrast options

* fix: use colour code from infusion

* fix: hover and focus stlying to uio tab

* fix: added styling for current page pagination

* fix: hover and focus styling comment in vendors scss

* fix: apply uio specific styles to uio plus themes

* fix: add hover and focus styling to contrast uio tab

* fix: refactor vendors scss

* fix: replace foregroundColor with fColor and backgroundColor with bColor

* fix: add media query to vendors scss

* fix: removed duplicate uio themes variable

* fix: removed uneeded comments form mixins

* fix: refactored contrast theme styling

moved selectors with curretColor value to mixins scss

* fix: remove uneeded comment

* fix: properly formated rem functions with negative input

* fix: moved each before media queries

* fix: refactored all uio contrast themes stlyling into mixins scss

* fix: placed media query for svg positioning inside mixins scss

* fix: added padding to uio tab on enhance inputs

to prevent hover/focus overlap

* fix: css clean up and adjust code comments

Co-authored-by: Cindy Qi Li <cli@ocadu.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TeddTech TeddTech

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

fix: UIO focus styling (resolves #231) TeddTech/wecount.inclusivedesign.ca
2 participants
@cindyli @TeddTech