fixed bug with BIDS sidecar files when supplied by user and updated tests #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cking for source_variable key which may not be in a BIDS json sidecar file. Also updated code so BIDS sidecar file is left untouched if user supplies one and selects -no_concepts flag on command line.
…IDS and sidecar file was provided and no annotations were made...also updated some of the function descriptive text for map_vars_to_terms
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #394 +/- ##
==========================================
+ Coverage 34.37% 34.44% +0.07%
==========================================
Files 52 52
Lines 6843 6849 +6
Branches 1674 1675 +1
==========================================
+ Hits 2352 2359 +7
+ Misses 4322 4318 -4
- Partials 169 172 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The map_vars_to_terms utility in pynidm was modifying json sidecar (mapping) files when they were supplied with a BIDS dataset and the user selected to do no annotations. This is fixed along with a new test / modified tests to accommodate this change.