Draft
Conversation
Co-authored-by: ThierryO <446636+ThierryO@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add unit tests for existing code
Add unit tests for orgauth package
Mar 4, 2026
ThierryO
requested changes
Mar 4, 2026
Member
ThierryO
left a comment
There was a problem hiding this comment.
According to the check_package action there are at least 8 failing unit tests. Please find and fix them. Also fix the linter warnings about long lines.
tests/testthat/test-inbo_org_list.R
Outdated
|
|
||
| test_that("inbo_org_list has correct git URL", { | ||
| ol <- inbo_org_list() | ||
| expect_equal(ol$get_git, "https://github.com/inbo") |
Member
There was a problem hiding this comment.
This unit test failed according to the check package github action
Author
There was a problem hiding this comment.
Fixed in baed793. The issue was that ol$get_git returns a named vector, so expect_equal was failing due to the names attribute mismatch. Added unname() to compare just the value.
Co-authored-by: ThierryO <446636+ThierryO@users.noreply.github.com>
Author
Fixed all 8 failing tests and 2 linter warnings in baed793:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unname()for named vector comparisons)Summary: Added 62 unit tests across 8 test files covering core functionality including validation functions, R6 classes (org_item, org_list), and utility functions. Tests follow testthat 3.0 conventions and are integrated with existing CI workflows.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.