-
Notifications
You must be signed in to change notification settings - Fork 0
510 create update translations workflow #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: uat
Are you sure you want to change the base?
Conversation
bring changes from 519 into 510
#510 I've added a arrange so in the future changes will be limited to actual changes more than shifts in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces improvements to the translation file processing workflow, enhances package management, and updates environment variable handling for file uploads. The changes focus on restructuring translation processing scripts, automating package installation, and improving robustness in file upload operations.
Key Changes:
- Created automated translation file processing workflow with intelligent input directory detection
- Added package management automation for translation processing requirements
- Enhanced S3 upload functionality with improved error handling and environment variable support
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Processing/processing_translation_files.Rmd | New RMarkdown script for automated translation file conversion and language-specific splitting |
| src/Processing/run_processing_translation_files.R | New script to extract and execute RMarkdown code chunks for translation processing |
| src/Processing/install_packages_processing_translation_files.R | New automated package installer for translation processing dependencies |
| src/upload_direct_to_UAT.R | Enhanced S3 upload script with improved bucket selection, recursive uploads, and conditional connection |
| .github/workflows/run_translations_processing.yaml | Updated workflow to use reorganized translation processing script path |
| .github/workflows/upload_files_direct.yaml | Added amiabot environment variable for automated execution detection |
| Multiple translation output files | Generated translation files in Dutch, French, and English with new language change confirmation strings |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
#525 This issue occurs on my home pc but even reïnstalling the relevant package doesn't fix a error stating %||% is not found.
Files changed: M data/output/UAT_direct/translations/translation_en.csv M data/output/UAT_direct/translations/translation_fr.csv M data/output/UAT_direct/translations/translation_nl.csv
…hub.com/inbo/aspbo into 510-create-update-translations-workflow
Files changed: M data/output/UAT_direct/translations/translation_en.csv M data/output/UAT_direct/translations/translation_fr.csv M data/output/UAT_direct/translations/translation_nl.csv
Files changed: M data/output/UAT_direct/translations/translation_en.csv
Files changed: M data/output/UAT_direct/translations/translation_nl.csv
…hub.com/inbo/aspbo into 510-create-update-translations-workflow
|
@soriadelva ga je er nog eens door ? Ik heb de meerderheid van de opmerkingen verwerkt of verhuisd naar een eigen issue (bvb #556) |
issues are mostly solved
Files changed: M data/output/UAT_direct/translations/translation_nl.csv
|
@soriadelva de laatste opmerkingen zijn verwerkt |
Files changed: M data/output/UAT_direct/translations/translation_en.csv M data/output/UAT_direct/translations/translation_fr.csv M data/output/UAT_direct/translations/translation_nl.csv
This pull request introduces a new workflow for processing translation files, updates documentation and translation data, and refactors the translation processing scripts for improved automation and maintainability. The most important changes are grouped below:
Workflow and Automation Improvements
.github/workflows/run_translations_processing.yamlnow sources the translation processing script from the new locationsrc/Processing/run_processing_translation_files.R, reflecting a refactor and improved organization of translation processing logic.src/Processing/run_processing_translation_files.Rto automatically run all chunks of the translation processing RMarkdown file, ensuring translations are processed consistently and reproducibly.src/Processing/install_packages_processing_translation_files.Rto ensure required R packages are installed before processing translations, improving robustness of the workflow.Documentation Updates
README.mdto include badges and links for the new translation processing and testing workflows, making it easier to monitor and access these automated processes.Translation Data and Processing
data/interim/translations/scaffold.txtindicating the planned move of translation files to a new folder, improving clarity for future organization.data/output/UAT_direct/translations.csvfor confirming language changes, enhancing the application's multilingual support.src/Processing/processing_translation_files.Rmdthat reads, combines, and splits translation files by language, then outputs them to the appropriate directory for use in the application.=> @soriadelva also check the wiki page https://github.com/inbo/aspbo/wiki/HOWTO#-edit-translations