Skip to content

Conversation

@SanderDevisscher
Copy link
Collaborator

@SanderDevisscher SanderDevisscher commented Sep 5, 2025

This pull request introduces a new workflow for processing translation files, updates documentation and translation data, and refactors the translation processing scripts for improved automation and maintainability. The most important changes are grouped below:

Workflow and Automation Improvements

  • The GitHub Actions workflow .github/workflows/run_translations_processing.yaml now sources the translation processing script from the new location src/Processing/run_processing_translation_files.R, reflecting a refactor and improved organization of translation processing logic.
  • Added the new script src/Processing/run_processing_translation_files.R to automatically run all chunks of the translation processing RMarkdown file, ensuring translations are processed consistently and reproducibly.
  • Added package installation logic in src/Processing/install_packages_processing_translation_files.R to ensure required R packages are installed before processing translations, improving robustness of the workflow.

Documentation Updates

  • Updated README.md to include badges and links for the new translation processing and testing workflows, making it easier to monitor and access these automated processes.

Translation Data and Processing

  • Added a scaffold note in data/interim/translations/scaffold.txt indicating the planned move of translation files to a new folder, improving clarity for future organization.
  • Added a new translation row to data/output/UAT_direct/translations.csv for confirming language changes, enhancing the application's multilingual support.
  • Introduced the new RMarkdown script src/Processing/processing_translation_files.Rmd that reads, combines, and splits translation files by language, then outputs them to the appropriate directory for use in the application.

=> @soriadelva also check the wiki page https://github.com/inbo/aspbo/wiki/HOWTO#-edit-translations

@SanderDevisscher SanderDevisscher added this to the v1.3.0 milestone Sep 5, 2025
@SanderDevisscher SanderDevisscher self-assigned this Sep 5, 2025
@SanderDevisscher SanderDevisscher linked an issue Sep 5, 2025 that may be closed by this pull request
4 tasks
@SanderDevisscher SanderDevisscher marked this pull request as draft September 5, 2025 11:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces improvements to the translation file processing workflow, enhances package management, and updates environment variable handling for file uploads. The changes focus on restructuring translation processing scripts, automating package installation, and improving robustness in file upload operations.

Key Changes:

  • Created automated translation file processing workflow with intelligent input directory detection
  • Added package management automation for translation processing requirements
  • Enhanced S3 upload functionality with improved error handling and environment variable support

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Processing/processing_translation_files.Rmd New RMarkdown script for automated translation file conversion and language-specific splitting
src/Processing/run_processing_translation_files.R New script to extract and execute RMarkdown code chunks for translation processing
src/Processing/install_packages_processing_translation_files.R New automated package installer for translation processing dependencies
src/upload_direct_to_UAT.R Enhanced S3 upload script with improved bucket selection, recursive uploads, and conditional connection
.github/workflows/run_translations_processing.yaml Updated workflow to use reorganized translation processing script path
.github/workflows/upload_files_direct.yaml Added amiabot environment variable for automated execution detection
Multiple translation output files Generated translation files in Dutch, French, and English with new language change confirmation strings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

SanderDevisscher and others added 2 commits September 5, 2025 14:03
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SanderDevisscher SanderDevisscher marked this pull request as ready for review September 5, 2025 12:04
SanderDevisscher and others added 13 commits November 3, 2025 12:05
#525

This issue occurs on my home pc but even reïnstalling the relevant package doesn't fix a error stating %||% is not found.
Files changed:
M	data/output/UAT_direct/translations/translation_en.csv
M	data/output/UAT_direct/translations/translation_fr.csv
M	data/output/UAT_direct/translations/translation_nl.csv
Files changed:
M	data/output/UAT_direct/translations/translation_en.csv
M	data/output/UAT_direct/translations/translation_fr.csv
M	data/output/UAT_direct/translations/translation_nl.csv
Files changed:
M	data/output/UAT_direct/translations/translation_en.csv
@SanderDevisscher SanderDevisscher marked this pull request as draft November 3, 2025 16:07
@SanderDevisscher
Copy link
Collaborator Author

@soriadelva ga je er nog eens door ? Ik heb de meerderheid van de opmerkingen verwerkt of verhuisd naar een eigen issue (bvb #556)

@SanderDevisscher SanderDevisscher marked this pull request as ready for review November 4, 2025 15:09
SanderDevisscher and others added 2 commits November 4, 2025 15:36
Files changed:
M	data/output/UAT_direct/translations/translation_nl.csv
@SanderDevisscher
Copy link
Collaborator Author

@soriadelva de laatste opmerkingen zijn verwerkt

Files changed:
M	data/output/UAT_direct/translations/translation_en.csv
M	data/output/UAT_direct/translations/translation_fr.csv
M	data/output/UAT_direct/translations/translation_nl.csv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated workflow enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create update translations workflow

4 participants