multicapture camera photos UI is not accounting for iphone (#2827) #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Increase space above in multicapture camera to account for notch and dynamic island * Adjust heights for dynamic island * Change to using safeareaview
kvangork
requested review from
kvangork and
jtklein
and removed request for
albullington
kvangork
approved these changes
Apr 10, 2025
jtklein
reviewed
Apr 10, 2025
There was a problem hiding this comment.
The Podfile.lock change is not really needed for the described UI change. I can see that it was in the cherry-picked PR where it probably should not have been.
By including it here whoever will build the app (@kvangork) for release probably needs to have not-committed changes to this file in order to build from this branch.
As long as we are aware of this and okay with it I can Approve.
The UI change is working as expected though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase space above in multicapture camera to account for notch and dynamic island
Adjust heights for dynamic island
Change to using safeareaview
MOB-612