Ai camera shutter button not tappable after first press #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angielt
changed the title
albullington
requested changes
Apr 9, 2025
| @@ -59,7 +59,7 @@ | |||
| </Testables> | |||
| </TestAction> | |||
| <LaunchAction | |||
| buildConfiguration = "Debug" | |||
| buildConfiguration = "Release" | |||
There was a problem hiding this comment.
Let's not change this in this PR.
| }; | ||
|
|
||
| const isDisabled = disabled || ( preventMultipleTaps && isProcessing ); | ||
|
|
||
| return ( | ||
| <Pressable |
There was a problem hiding this comment.
Being a tiny bit forward thinking here, can we move this logic into a SharedComponent, maybe called PressableWithDebounce? I'm assuming a few things here:
- we'll want this logic on other buttons throughout the app (maybe even in the camera, on the gallery button for example)
- it would be nice to be able to quickly swap out a
Pressablefor aPressableWithDebouncein case we run into any timing issues with this (here or elsewhere) - it's nicer to standardize the debounce time in a single location, rather than making
TakePhotoresponsible for receiving props and knowing how long to debounce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based off of solution for #2833