Display onboarding carousel as react-navigation modal #2845
Conversation
* Don't check for prev crashes or sentinel files on a fresh install * Make sure we're not accidentally creating a new legacy store on every install * Revert * Add splash screen, preload images, show onboarding as react nav modal * Fix e2e tests
There was a problem hiding this comment.
I think these changes are okay to make now. Overall it is an improvement to the current state. While it does address the two Linear issues linked, I am not sure it is at a stage were I am comfortable with as the first impression to new users though. There is still a flash of white between the two instances of the splash screen.
Also, I think the hoisting of the OnboardingModal should have been even higher to App.js with onboardingShown either returning the onboarding modal or the app content.
|
@jtklein regarding your question "I am not sure it is at a stage were I am comfortable with as the first impression to new users though. There is still a flash of white between the two instances of the splash screen." |
|
afaik (for the reasons mentioned here) the white flash is a separate issue related to how the entire React Native bundle loads, and it wasn't something i ever figured out how to fix while working on Seek. maybe something to revisit after Earth Day. |
This changes the way we display the OnboardingCarousel. By using react-navigation modal, we eliminate the glitchiness in the screen transition that was present when we needed to first navigate to MyObservations, then check for whether the onboarding screen had previously been displayed, then open the modal. This conditionally displays either Onboarding or MyObservations depending on whether Onboarding has been seen before.