Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error context to crash reporting #2843

Merged
merged 4 commits into from
Apr 10, 2025

Conversation

albullington
Copy link
Collaborator

For better or worse we haven't gotten the 429 errors in Grafana for build 0.59.16 yet that would confirm that this is working in a production environment, but we can simulate that it's working in by pressing the relevant 429 error button. This is intended to help us understand what a user was doing in the app before they receive a 429 error.

@albullington albullington requested a review from jtklein April 9, 2025 17:20
Copy link
Collaborator

@jtklein jtklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to trigger the error in the StartupService.js file within a timebox, but I am also sure that the change there is not a regression.

I am seeing some context in the server logs when triggered from logging.js, e.g.
429 in reactQueryRetry: {"queryKey":"[\"fetchTaxon\",48623]","failureCount":2,"timestamp":"2025-04-10T17:41:27.779Z","errorType":"INatApiTooManyRequestsError","status":429}.
I am not seeing context in the server logs when triggered from index.js
{"error":"Too Many Requests","status":429,"context":null}.

My current summary is that this needs more work to be helpful to find patterns of usage that trigger 429 errors.
But I don't see any harmfull regressions here so I Approve.

@albullington albullington merged commit 823aece into release-1.0 Apr 10, 2025
11 checks passed
@albullington albullington deleted the cherry-pick/tweaks-for-crash-reporting branch April 10, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants