This repository has been archived by the owner on Dec 12, 2021. It is now read-only.
Migrate to Swift 4 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, |
|
RxAutomaton.podspec needs to be updated to RxSwift 4.0, e.g.
|
inamiy
reviewed
Oct 20, 2017
There was a problem hiding this comment.
@jeffreylyg
Hi, thank you for fixes!
Overall looks good to me 👍
Would you mind changing the parts I commented, and also the followings:
- Change target branch to
swift/4.0 - Update
.swift-version - Update
Package.swiftandPackage.resolved - (If CI still fails) Comment-out
pod lib lintin.travis.yml
Demo/ViewController.swift
Outdated
| @@ -38,7 +38,7 @@ class AutomatonViewController: UIViewController | |||
| { | |||
| return Observable<Int>.interval(interval, scheduler: MainScheduler.instance) | |||
| .take(count) | |||
| .scan(0) { $0.0 + 1 } | |||
| .scan(0) { ($0, $1).0 + 1 } | |||
Sources/Automaton.swift
Outdated
| @@ -137,9 +137,9 @@ public final class Automaton<State, Input> | |||
|
|
|||
| // MARK: Private | |||
|
|
|||
| private func _compose<A, B, C>(_ g: @escaping (B) -> C, _ f: @escaping (A) -> B) -> (A) -> C | |||
| private func _compose<A, B, C, D>(_ g: @escaping ((B) -> C), _ f: @escaping ((A, D) -> B)) -> ((A, D) -> C) | |||
There was a problem hiding this comment.
Please change the use of type parameters in alphabetical order for readability, i.e.:
private func _compose<A, B, C, D>(_ g: @escaping ((C) -> D), _ f: @escaping ((A, B) -> C)) -> ((A, B) -> D)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.