[inaka/elvis#402] ct:print added to no_debug_call rule

inaka · Feb 9, 2017 · 5124902 · 5124902
1 parent 2d20d84
commit 5124902
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/src/elvis_style.erl b/src/elvis_style.erl
@@ -606,6 +606,11 @@ no_debug_call(Config, Target, RuleConfig) ->
     {Root, _} = elvis_file:parse_tree(Config, Target),
     ModuleName = elvis_code:module_name(Root),
     DefaultDebugFuns = [{ct, pal},
+                        {ct, print, 1},
+                        {ct, print, 2},
+                        {ct, print, 3},
+                        {ct, print, 4},
+                        {ct, print, 5},
                         {io, format, 1},
                         {io, format, 2}],
     DebugFuns = maps:get(debug_functions, RuleConfig, DefaultDebugFuns),

diff --git a/test/examples/fail_no_debug_call.erl b/test/examples/fail_no_debug_call.erl
@@ -11,4 +11,6 @@ fail() ->
     % Sending explicit io to a device is not considered debugging
     io:format(user, "Not a debug print ~s~n", ["Not debug"]),
     ct:pal("Debug"),
-    ct:pal("Debug ~s", ["Debug Info"]).
+    ct:pal("Debug ~s", ["Debug Info"]),
+    ct:print("Debug"),
+    ct:print("Debug ~s", ["Debug Info"]).
diff --git a/test/style_SUITE.erl b/test/style_SUITE.erl
@@ -525,7 +525,7 @@ verify_no_debug_call(_Config) ->
     PathFail = "fail_no_debug_call.erl",
     {ok, FileFail} = elvis_test_utils:find_file(SrcDirs, PathFail),
 
-    [_, _, _, _] = elvis_style:no_debug_call(ElvisConfig, FileFail, #{}),
+    [_, _, _, _, _, _] = elvis_style:no_debug_call(ElvisConfig, FileFail, #{}),
 
     RuleConfig = #{ignore => [fail_no_debug_call]},
     [] = elvis_style:no_debug_call(ElvisConfig, FileFail, RuleConfig),
@@ -538,7 +538,10 @@ verify_no_debug_call(_Config) ->
 
     RuleConfig4 = #{debug_functions => [{io, format}]},
     [_, _, _] =
-        elvis_style:no_debug_call(ElvisConfig, FileFail, RuleConfig4).
+        elvis_style:no_debug_call(ElvisConfig, FileFail, RuleConfig4),
+
+    RuleConfig5 = #{debug_functions => [{ct, print}]},
+    [_, _] = elvis_style:no_debug_call(ElvisConfig, FileFail, RuleConfig5).
 
 -spec verify_no_nested_try_catch(config()) -> any().
 verify_no_nested_try_catch(_Config) ->