-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align with Microprofile Health Check spec #24
Comments
One immediate opportunity: aligning with "checks" field instead of RFC's current "details", since there were concerns about "details" in RFC already: #20 |
MP Health recently broke back-compat by renaming "outcome"/"state" to "status"/"status". The only acceptable rationale (IMO) was to align with Spring Health Checks. Where MP Health is "checks"/"data", Spring is "details"/"details". So if we're really looking to synergize with Spring, then we are only part way there. The outcome/state to status/status change kind of irked me. I did a big audit of popular health check outputs last night, and there is little to no overall consistency or emergent standards here. To make better use of MP Health's 2.0 breaking changes, I'm trying to expand the scope of the considerations we will make so that we aren't breaking things just for nitpicky name changes like "I prefer status", "but I prefer outcome", "I don't care I just don't want you breaking my control plane automations", etc. |
Initial PR: #28 There're currently two major differences between RFC and microprofiles standard:
|
P.S. I noticed that @derekm already had 1st difference submitted as a change request in eclipse/microprofile-health#110 |
Fixing #24: Aligning with Microprofile spec
Find ways in which this RFC can better align with the microprofile spec for health checks: https://microprofile.io/project/eclipse/microprofile-health
The text was updated successfully, but these errors were encountered: