[BUGFIX] Resolve country select list without EXT:static:info_tables #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extension setting "overrideFeUserCountryFieldWithSelect" promises to activate country selection lists without requiring EXT:static_info_tables. A few minor fixes had to be applied to make it work in TYPO3 v12: - Enable dependency injection in StaticInfoTables.php, even if EXT:static_info_tables is not installed. - Provide selection items as ``` [] = [<label>, <iso-code>] ``` instead of ``` [<iso-code>] = <label> ``` as expected by the TCA procedures. - Sort UTF-8 labels by using the collator of the PHP intl extension. Inspired by the TYPO3 core. - Fetch the fully initialized language service from $GLOBALS['LANG']. Inspired by the TYPO3 core.
Contributor
Author
|
Dear in2code team, this PR should fix the issue 652. I have only run manual tests in the TYPO3 v12 backend for german and english language. Did not implement automatic tests. Greetings |
Contributor
|
planned for dev team: https://projekte.in2code.de/issues/73665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension setting "overrideFeUserCountryFieldWithSelect" promises to activate country selection lists without requiring EXT:static_info_tables. A few minor fixes had to be applied to make it work in TYPO3 v12:
[] = [<label>, <iso-code>]instead of[<iso-code>] = <label>as expected by the TCA procedures.Fixes: #652