replace derivative crate with derive_more crate #439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR carries over from #437 and changes the
derivative
crate to thederive_more
crate. This is particularly for theDebug
derives which were bandwhich's main usecase forderivative
.debug_fn
(formatting fn) in code, as it only adds a fixed string, so directly used that string in the macro.Default
derive, as our main use case for it was setting the default ofVerbosity
. ButVerbosity
itself is a simple struct having twou8
fields and aPhantomData
, which also does aderive(Default)
as the default foru8
is 0, the "normal" Default should be same asVerbosity::new(0, 0)
.