Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially fix flaky tests #308

Merged
merged 7 commits into from
Oct 17, 2023
Merged

Partially fix flaky tests #308

merged 7 commits into from
Oct 17, 2023

Commits on Oct 17, 2023

  1. Minor code style changes

    @cyqsimon
    cyqsimon committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    1863a74 View commit details
    Browse the repository at this point in the history

  2. Disable rendering of timestamps in tests

    @cyqsimon
    cyqsimon committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    db21cbf View commit details
    Browse the repository at this point in the history

  3. Update test snapshots

    @cyqsimon
    cyqsimon committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    0a27ebb View commit details
    Browse the repository at this point in the history

  4. Test everything with insta macros (no more assert(_eq)?) 

    - This has the benefit of creating snapshots for everything, allowing for later diffing
    @cyqsimon
    cyqsimon committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    763be53 View commit details
    Browse the repository at this point in the history

  5. Don't use assert_debug_snapshot for large string outputs 

    - This makes snapshots more human-inspectable
    @cyqsimon
    cyqsimon committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    9245bc7 View commit details
    Browse the repository at this point in the history

  6. Code style improvement on two tests 

    - `pause_by_space`
- `rearranged_by_tab`
    @cyqsimon
    cyqsimon committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    bc604df View commit details
    Browse the repository at this point in the history

  7. Minor code style improvements

    @cyqsimon
    cyqsimon committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    3e2e652 View commit details
    Browse the repository at this point in the history