Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry DNS only after timeout #127

Open
imsnif opened this issue Jan 16, 2020 · 5 comments
Open

Retry DNS only after timeout #127

imsnif opened this issue Jan 16, 2020 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@imsnif
Copy link
Owner

imsnif commented Jan 16, 2020

Right now, when we do our reverse-dns queries (getting the hostname of an ip address), if the request failed, we retry immediately. This can cause a lot of connections (also visible in the app!) to be opened if a request repeatedly fails.

It would be nice if we have some sort of progressive backoff mechanism for this... something like: wait for 1 second before retrying, then wait for 2, 4, etc.
@imsnif imsnif added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 16, 2020
@zhangxp1998
Copy link
Collaborator

Correct me if I'm wrong, currently we will retry every second?

@imsnif
Copy link
Owner Author

imsnif commented Jan 17, 2020

Yep. I have a bit of a spotty internet connection though, so sometimes my whole connections pane is filled with our own DNS requests for minutes on end (which we somehow classify as unknown, btw). I thought this can make things a little friendlier.

bigtoast added a commit to bigtoast/bandwhich that referenced this issue Jan 17, 2020
@bigtoast
(imsnif#127) Degrading retry DNS resolve. Needs tests
ac4e4bc
bigtoast added a commit to bigtoast/bandwhich that referenced this issue Jan 18, 2020
@bigtoast
(imsnif#127) Degrading retry DNS resolve. Needs tests
669e54b
@captain-yossarian
Copy link
Contributor

Hi @imsnif I would like to work on it. Could you please give me start point?

@imsnif
Copy link
Owner Author

imsnif commented Mar 2, 2020

@bigtoast is already working on it here: #133

@QuentinMoss
Copy link

@imsnif it looks like this was never completed and is quite old. Still relevant? Happy to pick it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@QuentinMoss @imsnif @zhangxp1998 @captain-yossarian