-
Notifications
You must be signed in to change notification settings - Fork 75
Fix mod_grad_axis() method #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- fixed tuple conversion - updated to new EventLibrary structure - added automatic cache clearing (important!) - updated documentation and type annotation - added empty sequence handling - added comprehensive tests for all cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Patrick,
Overall looks good! However the event library should not be modified in-place if it can be avoided. Use update to make sure the internal keymap stays valid.
I think currently a test like this would create a duplicate event:
- Add block with grad x
- Mod grad axis x * -1
- Add block with grad -x (here, event lib would not be able to find the modified event)
There are probably other cases, anything that involves find or insert_or_find.
Frank
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
closes #311