helium/onboarding: remove HasPrefPath() exception #846
+13
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this check was mostly intended to not break services access for pre-onboarding users. onboarding was introduced a long time ago (way before pre-0.0.1), so this is not a real concern anymore. it was still possible to make ShouldAccessServices() return `true` by toggling services.enabled off and on in onboarding; this change should make it so that it's not possible anymore (meaning the user has to navigate to the next step before services are truly enabled).
wukko
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this check was mostly intended to not break services access for pre-onboarding users. onboarding was introduced a long time ago (way before pre-0.0.1), so this is not a real concern anymore.
it was still possible to make ShouldAccessServices() return
trueby toggling services.enabled off and on in onboarding; this change should make it so that it's not possible anymore (meaning the user has to navigate to the next step before services are truly enabled).For your pull request to not get closed without review, please confirm that: