Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds full response object as third argument to rpc callback #60

Conversation

jonbretman
Copy link
Contributor

@jonbretman jonbretman commented May 3, 2018

First of all great work on including a generated client - makes life much easier.

This adds the full response as a third argument to the callback which is useful if you need access to response headers/trailers.

@jonnyreeves
Copy link
Contributor

Thanks for raising this patch.

In a similar vein to the discussion in #59, I'm not currently comfortable with us breaking away from the pattern/API present in the official node-grpc library.

Note that the official node-grpc API returns a client object from unary invocations which will dispatch an event when the metadata becomes available, perhaps you would consider implementing this in which was I would gladly land it.

Thanks

@jonbretman
Copy link
Contributor Author

@jonnyreeves makes sense. I'll take a look at doing that but #61 is more urgent 😄

@jonbretman jonbretman closed this May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants