Skip to content

Conversation

@ctbur
Copy link
Contributor

@ctbur ctbur commented Jan 5, 2022

Changes

Replaced include <climits> with include<limits> in all files. It was necessary to replace it in phtree/common/base_types.h to get the project to build on Linux with either GCC 11 or Clang 13. Other files were changed for consistency.

Compile error without the change: compile-error.log

Verification

Only built in on my machine.

@improbable-til improbable-til self-assigned this Jan 6, 2022
@improbable-til
Copy link
Contributor

Hi Cyrill,
Improbable requires a CLA to be signed (see here). Could you provide us with an email address for contact?

@improbable-til
Copy link
Contributor

I couldn't reproduce the problem with GCC 9, GCC 10, CLANG 9, CLANG 10, CLANG 11 or CLANG 12 on Ubuntu 20.04.
But I accept that <limits> is generally preferable to <climits>. I am currently testing this a bit more with MSVC.

@improbable-til
Copy link
Contributor

Thanks for contributing! :-)

@improbable-til improbable-til merged commit 93ac9c8 into improbable-eng:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants