Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: php dynamic property warning of $user_id in Give_Addon_Activation_Banner class #7587

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix: php dynamic property warning of $user_id in Give_Addon_Activation_Banner class #7587

merged 1 commit into from
Oct 28, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Oct 24, 2024 •
edited by jira bot
Loading

Resolves GIVE-1370

Description

This adds the $user_id property to the Give_Addon_Activation_Banner class to prevent the following php warning:

[24-Oct-2024 21:00:08 UTC] PHP Deprecated:  Creation of dynamic property Give_Addon_Activation_Banner::$user_id is deprecated in /Users/jonwaldstein/Herd/givewp/wp-content/plugins/give/includes/admin/class-addon-activation-banner.php on line 48

Affects

  • The banner activation banner dismissing functionality (user_id)

Visuals

N/A

Testing Instructions

  • Make sure you can dismiss an addon banner activation

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

pauloiankoski
pauloiankoski approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough!

rickalday
rickalday approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@jonwaldstein jonwaldstein merged commit 94bd65d into develop Oct 28, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the chore/php-warning-give-banner branch October 28, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloiankoski pauloiankoski pauloiankoski approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonwaldstein @rickalday @pauloiankoski