Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add form table upgrade row action #7465

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

kjohnson
Copy link
Member

@kjohnson kjohnson commented Jul 31, 2024

Resolves GIVE-1023

Description

This PR adds a new row action for v2 form in the forms table to upgrade a v2 form to a v3 form.

Affects

A new row action is added to the forms table.

Visuals

image

Form Edit Screen Forms Table Screen
image image

Testing Instructions

Create a v2 form.
Click the upgrade row action.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@kjohnson kjohnson marked this pull request as ready for review July 31, 2024 16:09
@kjohnson
Copy link
Member Author

@JoshuaHungDinh JoshuaHungDinh self-requested a review August 5, 2024 15:07
@JoshuaHungDinh
Copy link
Contributor

@kjohnson, am I on the right page for the row action?

Screenshot 2024-08-05 at 3 00 42 PM

@kjohnson
Copy link
Member Author

kjohnson commented Aug 6, 2024

@JoshuaHungDinh yeah, that is the right table/page. There should be a row action for "Upgrade" after "Duplicate" for v2 forms.

Make sure you run npm run build.

Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Awesome this looks good.

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@jonwaldstein jonwaldstein merged commit c6365d2 into develop Aug 21, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the feature/form-table-upgrade-row-action-GIVE-1023 branch August 21, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants