Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Add tests for form migration steps #7424

Merged
merged 12 commits into from
Aug 22, 2024

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Jun 26, 2024

Resolves GIVE-803

Description

This PR adds a helper method to be used when testing FormMIgration processes and updates the existing tests to use that helper.

Additionally, after reviewing them, I've found a bug with the ConvertKit process that required a fix: the conditional logic for canHandle was not correct when the selected option on v2 was to customize per form.

Affects

Form Migration tests

Testing Instructions

The only test to do here is regarding the ConvertKit issue I've found so:

  1. Using the current version of Give core, configure a v2 form with customized ConvertKit settings while not enabling it globally
  2. Migrate that form
  3. Confirm that ConvertKit settings have not been migrated correctly
  4. Upgrade Give to this version
  5. Repeat the process
  6. ConvertKit settings must have been migrated as expected now

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@pauloiankoski pauloiankoski changed the title test: add trait to help executing migrations steps Test: Add tests for form migration steps Jun 26, 2024
Copy link

This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed.

@github-actions github-actions bot added the Stale label Aug 12, 2024
@pauloiankoski pauloiankoski marked this pull request as ready for review August 21, 2024 14:48
@jonwaldstein jonwaldstein self-requested a review August 21, 2024 16:00
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@github-actions github-actions bot removed the Stale label Aug 22, 2024
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@pauloiankoski pauloiankoski merged commit 55b1c3b into develop Aug 22, 2024
20 checks passed
@pauloiankoski pauloiankoski deleted the test/form-migration-steps branch August 22, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants