Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Notices no longer break multi-step form receipt step. #5219

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

kjohnson
Copy link
Member

@kjohnson kjohnson commented Aug 28, 2020

Resolves #5199

Description

The Stripe SDK is throwing PHP deprecation notices when WP_DEBUG is enabled, which breaks the receipt step of the multi-step form template.

This prevents the notices from breaking the display using an output buffer to control the output and prevent the notices from displaying.

Affects

Visuals

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Changelog updated
  • Self Review of code and UX completed

Testing Instructions

  • Enabled WP_DEBUG
  • Connect to Stripe account
  • Make a donation using a credit card (Stripe).

@kjohnson kjohnson changed the base branch from develop to release/2.8.0 August 28, 2020 20:40
Copy link
Member

@DevinWalker DevinWalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple yet effective!

@lindseymacmillan lindseymacmillan merged commit 45abf23 into release/2.8.0 Aug 28, 2020
@lindseymacmillan lindseymacmillan deleted the fix/broken-receipt-notices-5199 branch August 28, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP notices should not prevent the final step from displaying on the new template
3 participants