-
Notifications
You must be signed in to change notification settings - Fork 0
Fetch wrappers plus relationship and property fetching modifiers #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ff3213d
WIP— property wrappers that expose fetch results based on queries
johnclayton 00a0d8a
wip
johnclayton 543ae93
wip
johnclayton c8cb123
wip
johnclayton 405bda4
wip
johnclayton 127b677
wip
johnclayton d523ab2
wip
johnclayton 4015d02
wip
johnclayton 959c787
See if we can fix that flaky test
johnclayton 983fedf
pr feedback
johnclayton 89eda3e
PR feedback
johnclayton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
Sources/SwiftQuery/FetchWrappers/DefaultModelContainerKey.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import Dependencies | ||
| import SwiftData | ||
|
|
||
| @Model final class Empty { | ||
| init() {} | ||
| } | ||
|
|
||
| enum DefaultModelContainerKey: DependencyKey { | ||
| static var liveValue: ModelContainer { | ||
| reportIssue( | ||
| """ | ||
| A blank, in-memory persistent container is being used for the app. | ||
| Override this dependency in the entry point of your app using `prepareDependencies`. | ||
| """ | ||
| ) | ||
| let configuration = ModelConfiguration(isStoredInMemoryOnly: true) | ||
| return try! ModelContainer(for: Empty.self, configurations: configuration) | ||
| } | ||
|
|
||
| static var testValue: ModelContainer { | ||
| liveValue | ||
| } | ||
| } | ||
|
|
||
| public extension DependencyValues { | ||
| var modelContainer: ModelContainer { | ||
| get { self[DefaultModelContainerKey.self] } | ||
| set { self[DefaultModelContainerKey.self] = newValue } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| import Foundation | ||
| import CoreData | ||
| import Dependencies | ||
| import SwiftData | ||
| #if canImport(SwiftUI) | ||
| import SwiftUI | ||
| #endif | ||
|
|
||
| @MainActor | ||
| @propertyWrapper | ||
| public final class FetchAll<Model: PersistentModel>: Observable { | ||
| public var wrappedValue: [Model] { | ||
| storage.wrappedValue | ||
| } | ||
| private var storage: Storage = .init() | ||
| private var subscription: (Task<Void, Never>)? | ||
| @Dependency(\.modelContainer) private var modelContainer | ||
|
|
||
| public init(_ query: Query<Model> = .init()) { | ||
| subscribe(query) | ||
| } | ||
|
|
||
| deinit { | ||
| subscription?.cancel() | ||
| } | ||
|
|
||
| private func subscribe(_ query: Query<Model>) { | ||
| debug { logger.debug("\(Self.self).\(#function)(query: \(String(describing: query))") } | ||
| subscription = Task { [modelContainer = self.modelContainer] in | ||
| do { | ||
| let initialResult = try query.results(in: modelContainer) | ||
| trace { | ||
| logger.trace("\(Self.self).results: \(String(describing: initialResult.map { $0.persistentModelID } ))") | ||
| } | ||
| storage.wrappedValue = initialResult | ||
|
|
||
| let changeNotifications = NotificationCenter.default.notifications(named: .NSPersistentStoreRemoteChange) | ||
|
|
||
| for try await _ in changeNotifications { | ||
| guard !Task.isCancelled else { break } | ||
| debug { logger.debug("\(Self.self).NSPersistentStoreRemoteChange")} | ||
| let result = try query.results(in: modelContainer) | ||
| trace { | ||
| logger.trace("\(Self.self).results: \(String(describing: result.map { $0.persistentModelID } ))") | ||
| } | ||
| storage.wrappedValue = result | ||
| } | ||
| } catch { | ||
| logger.error("\(error)") | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Observable | ||
| internal class Storage { | ||
| var wrappedValue: [Model] = [] | ||
| init() {} | ||
| } | ||
| } | ||
|
|
||
| #if canImport(SwiftUI) | ||
|
||
| extension FetchAll: DynamicProperty {} | ||
| #endif | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this anymore