-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #720 #858
Fix issue #720 #858
Conversation
Simply prevent eslint to check any parent folder of current working directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a test that would fail without this change?
1 similar comment
@ljharb Hi, I have added a unit test for this. Please kindly review. |
@ljharb Hi, any chance this commit could get merged? I believe the unit test error is not caused by changed code. Re-run the test might fix the issue. |
@laysent I'm unable to rerun appveyor tests; if you rebase and force push, that will trigger a rerun. |
@laysent please rebase from the command line; the UI "update" button creates a merge commit. |
Ah, great idea! thanks! |
Simply prevent eslint to check any parent folder of current working directory.
Fixes #720