Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #720 #858

Merged
merged 3 commits into from
Aug 27, 2017
Merged

Fix issue #720 #858

merged 3 commits into from
Aug 27, 2017

Conversation

laysent
Copy link
Contributor

@laysent laysent commented Jun 1, 2017

Simply prevent eslint to check any parent folder of current working directory.

Fixes #720

Simply prevent eslint to check any parent folder of current working
directory.
@coveralls
Copy link

coveralls commented Jun 1, 2017

Coverage Status

Coverage increased (+0.003%) to 95.133% when pulling 5fd356d on laysent:master into 28e1623 on benmosher:master.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test that would fail without this change?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.141% when pulling ac3d76a on laysent:master into 28e1623 on benmosher:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 1, 2017

Coverage Status

Coverage increased (+0.01%) to 95.141% when pulling ac3d76a on laysent:master into 28e1623 on benmosher:master.

@laysent
Copy link
Contributor Author

laysent commented Jun 1, 2017

@ljharb Hi, I have added a unit test for this. Please kindly review.

@laysent
Copy link
Contributor Author

laysent commented Jul 3, 2017

@ljharb Hi, any chance this commit could get merged? I believe the unit test error is not caused by changed code. Re-run the test might fix the issue.
Let me know if there is anything I can improve

@ljharb
Copy link
Member

ljharb commented Jul 3, 2017

@laysent I'm unable to rerun appveyor tests; if you rebase and force push, that will trigger a rerun.

@coveralls
Copy link

coveralls commented Aug 21, 2017

Coverage Status

Coverage increased (+0.008%) to 96.002% when pulling 006ddeb on laysent:master into cd77133 on benmosher:master.

@ljharb
Copy link
Member

ljharb commented Aug 21, 2017

@laysent please rebase from the command line; the UI "update" button creates a merge commit.

@benmosher
Copy link
Member

Ah, great idea! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants